node 4x retry - #74

@sonnyp Maybe you can take a peek at this one? Should be a lot closer.

I think all the Nan2 stuff is working - but the core tests are failing :/

Hey @sonnyp

Well, I'm close. Very close. Can't figure how why it's not throwing exceptions for fallback JS profiles properly...

I've got to stop working on this now (ran out of time). HUUUGE thanks goes out to anyone who spends some time on this for me :)

Thanks!

You should be able to replace all references to Handle with Local for maximum compatibility

Handle<Value> prepare(String::Value &str) should have a Nan::HandleScope scope; otherwise it'll leak data (looks like it has been till now anyway) and in this case it should be a Nan::EscapableHandleScope scope because you're returning a value from it.

https://github.com/nodejs/nan/blob/master/doc/scopes.md#nanescapablehandlescope - you also need to use scope.Escape(obj)

I did a write-up @ https://nodesource.com/blog/cpp-addons-for-nodejs-v4 about the upgrade process that's a bit more verbose than other resources currently available

closing this in favor of #72

@erulabs thanks!